Skip to content

fix: restore button focus state design #46800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djhi merged 1 commit into from
Jun 11, 2026
+2 −3
Merged

fix: restore button focus state design #46800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/ui/src/components/Button/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ const buttonVariants = cva(
`relative
flex items-center justify-center
cursor-pointer
inline-flex
items-center
Comment on lines -16 to -17

@djhi djhi Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate lines (see L14)

space-x-2
text-center
font-regular
Expand All @@ -24,6 +22,7 @@ const buttonVariants = cva(
outline-hidden
transition-all
outline-0
focus-visible:outline-solid

@djhi djhi Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The outline fix

focus-visible:outline-4
focus-visible:outline-offset-1
border
Expand All @@ -45,7 +44,7 @@ const buttonVariants = cva(
text-foreground
bg-alternative dark:bg-muted hover:bg-selection
border-strong hover:border-stronger
focus-visible:outline-brand-600
focus-visible:outline-border-strong
Comment on lines -48 to +47

@djhi djhi Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't feel right but maybe it was intended?

data-[state=open]:bg-selection
data-[state=open]:outline-brand-600
data-[state=open]:border-button-hover
Expand Down
Loading