rename sink to destination #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename sink to destination everywhere except in the db, api and config for backward compatibility reasons. The terms sink and destination should be used interchangeably while reading the code. Any new uses of the term sink is banned in new code, except when fixing any bugs in db, api or config layers. For consistency the remaining locations in db, api and config will also be renamed to destination but those need to be done carefully to avoid breaking backward compatibility.