Skip to content

Conversation

@imor
Copy link
Contributor

@imor imor commented May 26, 2025

Rename sink to destination everywhere except in the db, api and config for backward compatibility reasons. The terms sink and destination should be used interchangeably while reading the code. Any new uses of the term sink is banned in new code, except when fixing any bugs in db, api or config layers. For consistency the remaining locations in db, api and config will also be renamed to destination but those need to be done carefully to avoid breaking backward compatibility.

@imor imor requested a review from a team as a code owner May 26, 2025 04:21
@imor imor force-pushed the rs/rename-sink-to-destination branch from a262fb9 to 7d47477 Compare May 26, 2025 06:33
@coveralls
Copy link

coveralls commented May 26, 2025

Pull Request Test Coverage Report for Build 15248570307

Details

  • 25 of 30 (83.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 54.438%

Changes Missing Coverage Covered Lines Changed/Added Lines %
supabase_etl/src/clients/bigquery.rs 0 1 0.0%
supabase_etl/src/pipeline/destinations/bigquery.rs 0 4 0.0%
Totals Coverage Status
Change from base Build 15247700543: 0.04%
Covered Lines: 3533
Relevant Lines: 6490

💛 - Coveralls

@imor imor force-pushed the rs/rename-sink-to-destination branch from 7d47477 to d463074 Compare May 26, 2025 07:19
@imor imor merged commit 6ccec7e into main May 26, 2025
9 checks passed
@imor imor deleted the rs/rename-sink-to-destination branch May 26, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants