fix cyrillic layout switch key leak#179
Closed
yaroslavyaroslav wants to merge 1 commit into
Closed
Conversation
Contributor
|
i think the fix should stay smaller here. [32;1:3u looks like the space keyup, so i would only suppress the matching keyup after the layout switch and leave flagsChanged alone. swallowing modifier changes feels risky and it dont match upstream ghostty, which already moved away from that because it broke bindings. |
Contributor
|
superceded by the new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a keyboard input bug where switching to a Cyrillic/Russian layout could leak raw keyboard protocol fragments like
[32;1:3uinto the Codex terminal input.The root cause was that
keyDownwas already suppressed when the macOS input source changed, but the matchingkeyUpand modifier release events were still being forwarded to Ghostty. This change adds a narrow suppression window for those follow-up events and covers it with tests.Verification
xcodebuild test -project supacode.xcodeproj -scheme supacode -destination "platform=macOS" -only-testing:supacodeTests/ GhosttySurfaceViewTests CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY="" -skipMacroValidation -quietmake build-appmake testmake format