Focus tab's focused surface on tab bar click#345
Merged
Conversation
Clicking a tab in the tab bar only updated the selected tab id without moving keyboard focus to a surface. Route the click through WorktreeTerminalState.selectTab so selecting a tab always focuses that tab's focused surface (or its first visible surface).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clicking a tab in the tab bar now always gives keyboard focus to that tab's focused surface.
Why
The tab bar's
onSelectcalledTerminalTabManager.selectTab(id), which only updatesselectedTabId. It never moved keyboard focus to a surface, so clicking a tab left the previously focused surface (in another tab) as first responder.How
Route the click through
WorktreeTerminalState.selectTab(id)instead. That method already updates the tab manager selection and callsfocusSurface(in:), which focuses the tab's last-focused surface (or its first visible surface if none was recorded). Because it always callsfocusSurface(in:), clicking the already-selected tab also re-focuses its surface.No other tab-selection path is affected: the remaining
tabManager.selectTabcalls are internal toWorktreeTerminalState, and theWorktreeTerminalManagercommand path already routes throughWorktreeTerminalState.selectTab.Testing
make build-appsucceeds.make testpasses.