Add "Manage GitHub access" link to the account dropdown#78
Merged
Conversation
Newly added repositories need the GitHub App granted access before the app can read/write their issues. Add a "Manage GitHub access" item to the signed-in user dropdown (next to "Sign out") that opens GitHub's installed-apps settings (https://github.com/settings/installations), where repository access for the app can be added or removed. Tests + 100% coverage + lint all green (966 tests). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019VQjXJyM3EZPd4joy3EwaB
Point the "Manage GitHub access" link at the dashban app's installation target (github.com/apps/dashban/installations/select_target) so it lands directly on the app's repo selection, instead of the generic installed-apps list. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019VQjXJyM3EZPd4joy3EwaB
Widen the user dropdown (w-48 -> w-56) and add whitespace-nowrap so "Manage GitHub access" no longer wraps to two lines. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019VQjXJyM3EZPd4joy3EwaB
select_target dumped the user on GitHub's account-picker. Link to the app's page (github.com/apps/dashban) instead; one Configure click opens the repo-access settings. (A static link can't reach the per-install repo-access page directly without the installation id.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019VQjXJyM3EZPd4joy3EwaB
|
🚅 Deployed to the dashban-pr-78 environment in dashban
|
Look up the user's dashban installation id (GET /user/installations via the existing authenticated proxy) and point the link straight at github.com/settings/installations/<id> — the page that lands directly on the app's repository access. The result is cached after the first lookup; until it resolves (or if the lookup fails / there's no install) the link falls back to the app's page. No new backend endpoint — it reuses the GitHub proxy. Also switch the github-auth test's module reset to jest.resetModules(); the previous delete-require.cache was a no-op under Jest, which let module-level state leak between tests. Tests + 100% coverage + lint all green (973 tests). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019VQjXJyM3EZPd4joy3EwaB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Manage GitHub access item to the signed-in user (account) dropdown in the header, next to "Sign out". It opens GitHub's installed-apps settings (
https://github.com/settings/installations) in a new tab.Why
When you add a repo to dashban, the GitHub App still needs to be granted access to that repo before it can read/write its issues. This puts a one-click path to manage that access in the account menu.
Note
Supersedes #77 — same change, moved to its own dedicated branch (
claude/manage-github-access) so Railway's per-PR preview deploy fires for it. Future changes will each get their own branch too.The link lands on your Installed GitHub Apps list. If you want it to deep-link straight to the dashban app's repo-picker, send me the app slug (
github.com/apps/<slug>).Testing
npm test— 966 passing.npm run test:coverage— 100% across all files.npm run lint— 0 errors (7 pre-existing warnings unchanged).🤖 Generated with Claude Code
https://claude.ai/code/session_019VQjXJyM3EZPd4joy3EwaB
Generated by Claude Code