Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/superannotate/lib/app/interface/sdk_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,14 @@ def rename_project(project: str, new_name: str):
:param new_name: project's new name
:type new_name: str
"""
controller.update_project(name=project, project_data={"name": new_name})

response = controller.update_project(name=project, project_data={"name": new_name})
if response.errors:
raise AppException(response.errors)

logger.info(
"Successfully renamed project %s to %s.", project, response.data["name"]
)


@Trackable
Expand Down
4 changes: 3 additions & 1 deletion src/superannotate/lib/core/usecases.py
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,9 @@ def execute(self):
if self.is_valid():
for field, value in self._project_data.items():
setattr(self._project, field, value)
self._projects.update(self._project)
new_project = self._projects.update(self._project)
self._response.data = new_project.to_dict()
return self._response


class CloneProjectUseCase(BaseUseCase):
Expand Down
3 changes: 2 additions & 1 deletion src/superannotate/lib/infrastructure/repositories.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,10 @@ def insert(self, entity: ProjectEntity) -> ProjectEntity:

def update(self, entity: ProjectEntity):
condition = Condition("team_id", entity.team_id, EQ)
self._service.update_project(
result = self._service.update_project(
entity.to_dict(), query_string=condition.build_query()
)
return self.dict2entity(result)

def delete(self, entity: ProjectEntity):
team_id = entity.team_id
Expand Down
2 changes: 1 addition & 1 deletion src/superannotate/lib/infrastructure/services.py
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def update_project(self, data: dict, query_string: str = None) -> bool:
if query_string:
url = f"{url}?{query_string}"
res = self._request(url, "put", data)
return res.ok
return res.json()

def attach_files(
self,
Expand Down
8 changes: 6 additions & 2 deletions tests/integration/test_project_rename.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,17 @@ class TestProjectRename(BaseTestCase):
PROJECT_DESCRIPTION = "Desc"
PROJECT_TYPE = "Vector"
NEW_PROJECT_NAME = "new"
REPLACED_PROJECT_NAME = "_ _ _ _ _ _ _ _ _"
BAD_PROJECT_NAME = '/ \ : * ? " < > |'

def test_project_rename(self):
sa.rename_project(self.PROJECT_NAME, self.NEW_PROJECT_NAME)
meta = sa.get_project_metadata(self.NEW_PROJECT_NAME)
assert meta["name"] == self.NEW_PROJECT_NAME
sa.delete_project(self.NEW_PROJECT_NAME)

def test_rename_with_special_characters(self):
sa.rename_project(self.PROJECT_NAME, '/ \ : * ? " < > |')
sa.get_project_metadata("_ _ _ _ _ _ _ _ _")
sa.rename_project(self.PROJECT_NAME, self.BAD_PROJECT_NAME)
sa.get_project_metadata(self.REPLACED_PROJECT_NAME)
sa.delete_project(self.REPLACED_PROJECT_NAME)