1297 download large files #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaghinakDev
requested changes
Sep 5, 2022
| if self.api_url != constance.BACKEND_URL: | ||
| return "https://assets-provider.devsuperannotate.com/api/v1.01/" | ||
| return "https://assets-provider.superannotate.com/api/v1.01/" | ||
| def get_assets_provider_url(self, version = 'v2'): |
Contributor
There was a problem hiding this comment.
We always should use one version of the assets provider in this case V2
| URL_START_FILE_SYNC = "items/{item_id}/annotations/sync" | ||
| URL_START_FILE_SYNC_STATUS = "items/{item_id}/annotations/sync/status" | ||
| URL_CLASSIFY_ITEM_SIZE = "items/annotations/download/method" | ||
| URL_SYNC_LARGE_ANNOTATION = "items/{}/annotations/sync" |
Contributor
There was a problem hiding this comment.
Suggested change
| URL_SYNC_LARGE_ANNOTATION = "items/{}/annotations/sync" | |
| URL_SYNC_LARGE_ANNOTATION = "items/{item_id}/annotations/sync" |
to avoid mistakes and suggest input
| URL_START_FILE_SYNC = "items/{item_id}/annotations/sync" | ||
| URL_START_FILE_SYNC_STATUS = "items/{item_id}/annotations/sync/status" | ||
| URL_CLASSIFY_ITEM_SIZE = "items/annotations/download/method" | ||
| URL_SYNC_LARGE_ANNOTATION = "items/{}/annotations/sync" |
Contributor
There was a problem hiding this comment.
Suggested change
| URL_SYNC_LARGE_ANNOTATION = "items/{}/annotations/sync" | |
| URL_SYNC_LARGE_ANNOTATION = "items/{item_id}/annotations/sync" |
| "version":"V1.00" | ||
| } | ||
|
|
||
| url = urljoin(self.get_assets_provider_url('v1.01'), f'items/{item_id}/annotations/download') |
Contributor
There was a problem hiding this comment.
To keep consistency let's use class variables for URLs
| "project_id": project_id, | ||
| "desired_transform_version": "export", | ||
| "desired_version":"V1.00", | ||
| "current_transform_version": "V1.00", |
Contributor
There was a problem hiding this comment.
desired_version and current_transform_version should not be hard coded(lats hard coded as class variable) )
| } | ||
|
|
||
| url = urljoin( | ||
| self.get_assets_provider_url('v2'), 'items/annotations/download/method' |
Contributor
There was a problem hiding this comment.
We already have a class variable for this URL
| await asyncio.sleep(1) | ||
|
|
||
|
|
||
| async with aiohttp.ClientSession( |
Contributor
There was a problem hiding this comment.
You can add "raise_for_status=True" to not handle each request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.