1304 add items to subset #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaghinakDev
reviewed
Sep 22, 2022
| if not response.ok: | ||
| raise AppException(response.json().get("errors", "undefined")) | ||
|
|
||
| reporter.log_info("You've successfully created a new subset - {subset name}.") |
Contributor
There was a problem hiding this comment.
Please move to usecase
|
|
||
| return None | ||
|
|
||
| def create_subset(self, team_id, project_id, subset_name, reporter): |
Contributor
There was a problem hiding this comment.
return created one instead of list
| return self._response | ||
|
|
||
|
|
||
| class AddItemsToSubsetUseCase(BaseUseCase): |
Contributor
There was a problem hiding this comment.
please add validation (like in the get_subsets at your discretion)
VaghinakDev
reviewed
Sep 22, 2022
| ) | ||
|
|
||
| try: | ||
| queried_items = query_use_case.execute().data |
Contributor
There was a problem hiding this comment.
no exception should be thrown there
you can check if there is any error via UseCase.execute().errors
VaghinakDev
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.