Skip to content

Fixed add_annotation_bbox/comment/point_to image #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VaghinakDev merged 1 commit into from
Oct 14, 2022
Merged

Fixed add_annotation_bbox/comment/point_to image #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions src/superannotate/lib/app/interface/sdk_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1971,7 +1971,7 @@ def add_annotation_bbox_to_image(
response = self.controller.annotations.list(
project=project, folder=folder, item_names=[image_name], verbose=False
)
if response.errors:
if not response.data:
raise AppException("Image not found.")
if response.data:
annotations = response.data[0]
Expand Down Expand Up @@ -2030,12 +2030,10 @@ def add_annotation_point_to_image(
]:
raise AppException(LIMITED_FUNCTIONS[project.type])
response = self.controller.annotations.list(
project=project,
folder=folder,
item_names=[image_name],
project=project, folder=folder, item_names=[image_name], verbose=False
)
if response.errors:
raise AppException(response.errors)
if not response.data:
raise AppException("Image not found.")
if response.data:
annotations = response.data[0]
else:
Expand Down Expand Up @@ -2090,12 +2088,10 @@ def add_annotation_comment_to_image(
raise AppException(LIMITED_FUNCTIONS[project.type])
project, folder = self.controller.get_project_folder(project_name, folder_name)
response = self.controller.annotations.list(
project=project,
folder=folder,
item_names=[image_name],
project=project, folder=folder, item_names=[image_name], verbose=False
)
if response.errors:
raise AppException(response.errors)
if not response.data:
raise AppException("Image not found.")
if response.data:
annotations = response.data[0]
else:
Expand Down
7 changes: 7 additions & 0 deletions tests/integration/annotations/test_annotations_upload_status_change.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import src.superannotate.lib.core as constances
from src.superannotate import SAClient
from src.superannotate import AppException
from tests.integration.base import BaseTestCase

sa = SAClient()
Expand Down Expand Up @@ -74,6 +75,12 @@ def test_add_annotation_bbox_to_image__annotation_status(self, reporter):
sa.get_item_metadata(self.PROJECT_NAME, self.IMAGE_NAME)["annotation_status"]
)

def test_add_annotation_bbox_to_image_not_existing_image(self, reporter):
reporter_mock = MagicMock()
reporter.return_value = reporter_mock
with self.assertRaisesRegexp(AppException, "Image not found."):
sa.add_annotation_bbox_to_image(self.PROJECT_NAME, "self.IMAGE_NAME", [1, 2, 3, 4], "bbox")

@pytest.mark.flaky(reruns=2)
@patch("lib.infrastructure.controller.Reporter")
def test_add_annotation_comment_to_image__annotation_status(self, reporter):
Expand Down