changed SDK auth flow #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaghinakDev
reviewed
Apr 13, 2023
| first_name: Optional[str] | ||
| last_name: Optional[str] | ||
| email: Optional[str] | ||
| picture: Optional[str] |
VaghinakDev
requested changes
Apr 13, 2023
Comment on lines
619
to
628
| try: | ||
| response = self._service_provider.get_user(self._team_id) | ||
| if not response.ok: | ||
| raise AppException(response.error) | ||
| self._response.data = response.data | ||
| except Exception: | ||
| raise AppException( | ||
| "Unable to retrieve user data. Please verify your credentials." | ||
| ) from None | ||
| return self._response |
Contributor
There was a problem hiding this comment.
Suggested change
| try: | |
| response = self._service_provider.get_user(self._team_id) | |
| if not response.ok: | |
| raise AppException(response.error) | |
| self._response.data = response.data | |
| except Exception: | |
| raise AppException( | |
| "Unable to retrieve user data. Please verify your credentials." | |
| ) from None | |
| return self._response | |
| response = self._service_provider.get_user(self._team_id) | |
| if not response.ok: | |
| self._response.errors =AppException( | |
| "Unable to retrieve user data. Please verify your credentials." | |
| ) | |
| else: | |
| self._response.data = response.data | |
| return self._response |
Comment on lines
837
to
841
| def get_current_user(self): | ||
| return usecases.GetCurrentUserUseCase( | ||
| service_provider=self.service_provider, team_id=self.team_id | ||
| ).execute() | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| def get_current_user(self): | |
| return usecases.GetCurrentUserUseCase( | |
| service_provider=self.service_provider, team_id=self.team_id | |
| ).execute() | |
| def get_current_user(self) -> UserEntity: | |
| response = usecases.GetCurrentUserUseCase( | |
| service_provider=self.service_provider, team_id=self.team_id | |
| ).execute() | |
| if response.errors: | |
| raise AppException(response.errors) | |
| return response.data | |
| return self._user | ||
|
|
||
| @staticmethod | ||
| def validate_token(token: str): |
VaghinakDev
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.