Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/superannotate/lib/app/interface/sdk_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -2321,10 +2321,10 @@ def get_annotations(
if isinstance(project, str):
project, folder = self.controller.get_project_folder_by_path(project)
else:
project, folder = (
self.controller.get_project_by_id(project_id=project).data,
None,
)
project = self.controller.get_project_by_id(project_id=project).data
folder = self.controller.get_folder_by_id(
project_id=project.id, folder_id=project.folder_id
).data
response = self.controller.annotations.list(project, folder, items)
if response.errors:
raise AppException(response.errors)
Expand Down
11 changes: 5 additions & 6 deletions src/superannotate/lib/core/usecases/annotations.py
Original file line number Diff line number Diff line change
Expand Up @@ -1114,7 +1114,7 @@ def execute(self):
reporter=Reporter(log_info=False),
project=self._project,
folder=self._folder,
item_names=[self._video_name],
items=[self._video_name],
service_provider=self._service_provider,
).execute()
if response.data:
Expand Down Expand Up @@ -1628,8 +1628,6 @@ def execute(self):
try:
annotations = run_async(self.run_workers(large_items, small_items))
except Exception as e:
# todo remove
raise e
logger.error(e)
self._response.errors = AppException("Can't get annotations.")
return self._response
Expand Down Expand Up @@ -1663,9 +1661,10 @@ def __init__(
self._big_file_queue = None

def validate_items(self):
self._item_names = GetAnnotations.items_duplication_validation(
self.reporter, self._item_names
)
if self._item_names:
self._item_names = GetAnnotations.items_duplication_validation(
self.reporter, self._item_names
)

@property
def destination(self) -> str:
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_image_upload.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,4 @@ def test_multiple_image_upload_with_duplicates(self):
)
self.assertEqual(len(uploaded), 3)
self.assertEqual(len(could_not_upload), 0)
self.assertEqual(len(existing_images), 2)
self.assertEqual(len(existing_images), 0)
2 changes: 1 addition & 1 deletion tests/integration/test_recursive_folder.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def test_recursive_upload(self):
self.PROJECT_NAME, self.second_folder_path, recursive_subfolders=True
)
self.assertEqual(2, len(uploaded))
self.assertEqual(2, len(duplicated))
self.assertEqual(0, len(duplicated))

def test_non_recursive_annotations_folder(self):
sa.upload_images_from_folder_to_project(
Expand Down