feat(fallbacks): add Cooper Black -> Caprasimo (Regular-only, metric_safe)#45
Merged
Merged
Conversation
…safe) Caprasimo is a deliberate advance-clone of Cooper Black: across the Latin core every measured advance is identical (mean 0.00%, worst 0.00%), so the Regular face earns a direct metric_safe verdict with no glyph exceptions. It supplies only Regular, so bold/italic/boldItalic resolve to face_missing rather than being faux-styled onto a face the font does not have. Same shape as Baskerville Old Face -> Bacasime Antique, one tier cleaner. Restores a concise reviewed-record-to-package path so the row is added from evidence, not by hand-editing the generated module: records.json is the only file a reviewer edits, scripts/generate-data.ts renders src/data.ts from it, and data-drift.test.ts re-renders in memory and fails if the checked-in module ever drifts from the source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Cooper Black as a measured fallback. Caprasimo is a deliberate advance-clone of Cooper Black: across the Latin core every advance is identical (mean 0.00%, worst 0.00%), so the Regular face earns a direct
metric_safeverdict with no glyph exceptions. It supplies only Regular, so bold/italic/boldItalic resolve toface_missingrather than being faux-styled onto a face the font lacks - the same shape as Baskerville Old Face -> Bacasime Antique, one tier cleaner.This also restores a concise reviewed-record-to-package path so a row is added from evidence, not by hand-editing the generated module. The tradeoff considered: keep editing
src/data.tsdirectly (fewer files) versus a source file plus generator. The generated module is large and easy to corrupt by hand, so a single editablerecords.jsonwith a pure generator and a byte-level drift guard is the safer long-term shape - and it leaves the public package growing from measurement, not vendor lists.records.jsonis the only file a reviewer edits;scripts/generate-data.tsrenderssrc/data.ts(runbun run gen:data).data-drift.test.tsre-renders in memory and byte-compares the checked-in module, so a hand-edit or a stale regenerate fails.asset_missing, so it stays inert until the font is actually shipped.Review: confirm the generator round-trips the prior 22 rows unchanged (diff is the header line + the new row only) and that the face-aware tests reject bold/italic misrouting. Ignore the biome-ignored
src/data.tsformatting - it is generated.Verified: bun run check -> typecheck ok, 30 tests across 4 files pass, biome clean, build ok; drift test -> fails on a stray edit, passes after regenerate.