Skip to content

HAR-7163 - extend core with attribute support#13

Merged
harbournick merged 2 commits into
super-editorfrom
artem-editor-v3
Jul 1, 2024
Merged

HAR-7163 - extend core with attribute support#13
harbournick merged 2 commits into
super-editorfrom
artem-editor-v3

Conversation

@artem-harbour
Copy link
Copy Markdown
Contributor

Linear:
https://linear.app/harbour/issue/HAR-7163/core-editor-infrastructure

  • Created Attribute class that is a space for methods of working with attributes.
  • Moved related methods from Schema class.
  • Added additional methods that add support for attributes in extensions.

@mattConnHarbour
Copy link
Copy Markdown
Contributor

Cool, I was just working with attributes on text nodes

Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/**
* Attribute class is used to work with attributes.
*/
export class Attribute {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@harbournick harbournick merged commit 66c96a1 into super-editor Jul 1, 2024
@harbournick harbournick deleted the artem-editor-v3 branch August 23, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants