fix: preserve style on row insertion #1553
Conversation
caio-pizzol
requested review from
VladaHarbour,
afn,
andrii-harbour,
artem-harbour,
harbournick and
luccas-harbour
and removed request for
artem-harbour
|
@caio-pizzol can you please test that this version of SD would work while being used in SuperDoc Services? |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| for (let i = 0; i < insertIndex; i++) { | ||
| insertPos += tableNode.child(i).nodeSize; | ||
| } | ||
|
|
||
| tr.insert(insertPos, newRow); |
There was a problem hiding this comment.
The new insertRowAtIndex path just clones the source row and inserts it at the computed position without running the prosemirror-tables row insertion logic that splits or adjusts cells spanning multiple rows. If the table contains any rowspan > 1 cells around the insertion point (e.g., a merged cell above or below the cursor), those spans are left intact while the cloned row reuses the same rowspan attrs, causing overlapping cells and an invalid TableMap when the document is next read. The previous originalAddRowBefore/After implementations handled rowspans; this change regresses merged-row tables.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
this may be a relevant concern for complex tables. if you start with:
then 'add row before' on the first row: 
there may be other weird cases. Should check vertical and horizontally merged cases.
harbournick
left a comment
harbournick
left a comment
There was a problem hiding this comment.
pls check cases with v or h merged cells
harbournick
force-pushed
the
main
branch
2 times, most recently
from
84f8ea5 to
2a443d8
Compare
No description provided.