refactor: simplify paragraph and table converters in pm-adapter (SD-1587) #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15f7386045
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
luccas-harbour
force-pushed
the
luccas/sd-1587-refactor-pm-adapter-in-layout-engine-part1
branch
from
253491b to
426f133
Compare
harbournick
approved these changes
Jan 22, 2026
Collaborator
harbournick
left a comment
harbournick
left a comment
There was a problem hiding this comment.
LGTM - nice!! So much cleaner
harbournick
deleted the
luccas/sd-1587-refactor-pm-adapter-in-layout-engine-part1
branch
harbournick
pushed a commit
that referenced
this pull request
Jan 22, 2026
…1806) * fix: remove dead code * refactor: table and paragraph converters to avoid redirection * test: adjust existing tests * fix: remove unused imports and dead code * fix: pass theme colors to node handlers * refactor: simplify type definitions for converters --------- Co-authored-by: Luccas Correa <luccas@superdoc.dev>
harbournick
pushed a commit
that referenced
this pull request
Jan 22, 2026
## [1.8.2-next.1](v1.8.1...v1.8.2-next.1) (2026-01-22) ### Bug Fixes * simplify paragraph and table converters in pm-adapter (SD-1587) ([#1806](#1806)) ([fa009bb](fa009bb))
harbournick
pushed a commit
that referenced
this pull request
Jan 22, 2026
## [1.8.2](v1.8.1...v1.8.2) (2026-01-22) ### Bug Fixes * simplify paragraph and table converters in pm-adapter (SD-1587) ([#1806](#1806)) ([fa009bb](fa009bb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paragraphToFlowBlocksandtableNodeToBlockfunctions used to accept a very large number of parameters. This was changed so an object is passed instead.