-
Notifications
You must be signed in to change notification settings - Fork 67
feat: enabled telemetry by default and added documentation #2001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enabled telemetry by default and added documentation #2001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ac924f34b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ocking in smoke tests
…ture - Introduced a new telemetry resource documentation in `resources/telemetry.mdx` detailing the telemetry data collection process and configuration options. - Updated `docs.json` to include the new telemetry documentation in the resources section. - Added a `DocCounter` component in `doc-counter.jsx` to track and display unique document counts during usage. - Enhanced the `SuperConverter` class to utilize SHA-256 for generating document identifiers, improving hash stability and security.
- Updated the visual harness initialization to set telemetry.enabled to false, ensuring telemetry is disabled during visual tests.
harbournick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels a bit risky to merge this and go direct to stable tbh with the super converter lib changes. if hash changes are necessary we should keep it in main longer IMO and we need test coverage for the new fns
packages/super-editor/src/core/super-converter/SuperConverter.js
Outdated
Show resolved
Hide resolved
harbournick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
🎉 This PR is included in superdoc v1.13.0-next.1 The release is available on GitHub release |
No description provided.