Skip to content

SD-1708: Footnotes overlap footer and fall off the page#2021

Merged
harbournick merged 6 commits intomainfrom
sd-1708_footnotes-overlap
Feb 18, 2026
Merged

SD-1708: Footnotes overlap footer and fall off the page#2021
harbournick merged 6 commits intomainfrom
sd-1708_footnotes-overlap

Conversation

@VladaHarbour
Copy link
Copy Markdown
Contributor

Hi team! Here I had to remove default top/bottom padding for table cells because it caused inconsistency between Superdoc and Word layouts(Superdoc tables occupied more space on the page that similar ones in Word). Also it caused issues in footnotes reserves calculations.

@linear
Copy link
Copy Markdown

linear Bot commented Feb 13, 2026

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7e093b892f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/layout-engine/layout-bridge/src/incrementalLayout.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 13, 2026

Visual diffs detected

Pixel differences were found in visual tests. This is not blocking — reproduce locally with cd tests/visual && pnpm docs:download && pnpm test to review diffs.

Copy link
Copy Markdown
Contributor

@caio-pizzol caio-pizzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @VladaHarbour!

Comment thread packages/layout-engine/layout-bridge/src/incrementalLayout.ts Outdated
Comment thread packages/layout-engine/layout-bridge/src/incrementalLayout.ts Outdated
Comment thread packages/layout-engine/layout-bridge/src/incrementalLayout.ts
Comment thread packages/layout-engine/painters/dom/src/table/renderTableCell.ts
Comment thread packages/layout-engine/measuring/dom/src/index.test.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 16, 2026

⚠️ AI Risk Review — potential issues found

  • Cell padding change will alter rendered height of all existing tables, breaking visual fidelity
  • No test coverage for max-pass scenario where reserves fail to stabilize
  • Performance risk: up to 4 full layoutDocument calls per incremental layout with footnotes

Via L3 deep analysis · critical risk

Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick merged commit 10ff3c7 into main Feb 18, 2026
5 checks passed
@harbournick harbournick deleted the sd-1708_footnotes-overlap branch February 18, 2026 01:52
@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Feb 18, 2026

🎉 This PR is included in superdoc v1.15.0-next.5

The release is available on GitHub release

@harbournick
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in superdoc v1.15.0

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Mar 11, 2026

🎉 This PR is included in superdoc-cli v0.2.0

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants