Skip to content

fix(tracked-changes): sync tracked changes store on undo and redo#2164

Merged
palmer-cl merged 7 commits intomainfrom
colep/sd-1893-bug-undo-tracked-change-leaves-suggestion-bubble-side-panel
Mar 6, 2026
Merged

fix(tracked-changes): sync tracked changes store on undo and redo#2164
palmer-cl merged 7 commits intomainfrom
colep/sd-1893-bug-undo-tracked-change-leaves-suggestion-bubble-side-panel

Conversation

@palmer-cl
Copy link
Collaborator

  • fix undo and redo logic with tracked changes
  • add behavior tests and visual tests

@linear
Copy link

linear bot commented Feb 24, 2026

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48eb61710e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Contributor

@caio-pizzol caio-pizzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid fix - guard removal + explicit sync on undo/redo addresses the actual data flow gap (PR #2195 will prob conflict here)

…o-tracked-change-leaves-suggestion-bubble-side-panel
caio-pizzol

This comment was marked as outdated.

Copy link
Contributor

@caio-pizzol caio-pizzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palmer-cl no blocking issues. the comment id cleanup from last round looks good.

one thing: the isHistoryType check in PresentationEditor.ts is now a duplicate — left an inline comment. removing it also fixes the failing unit test.

tests look good. two nice-to-have behavior tests: one that redo brings the bubble back after undo removes it, and one that nothing happens when the document didn't actually change.

feel free to merge after addressing the comments.

@palmer-cl palmer-cl merged commit 94f0056 into main Mar 6, 2026
8 checks passed
@palmer-cl palmer-cl deleted the colep/sd-1893-bug-undo-tracked-change-leaves-suggestion-bubble-side-panel branch March 6, 2026 08:20
@superdoc-bot
Copy link
Contributor

superdoc-bot bot commented Mar 6, 2026

🎉 This PR is included in superdoc v1.18.0-next.27

The release is available on GitHub release

@superdoc-bot
Copy link
Contributor

superdoc-bot bot commented Mar 6, 2026

🎉 This PR is included in superdoc-cli v0.2.0-next.101

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants