Conversation
palmer-cl
commented
Feb 24, 2026
- fix undo and redo logic with tracked changes
- add behavior tests and visual tests
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48eb61710e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/superdoc/src/components/CommentsLayer/FloatingComments.vue
Outdated
Show resolved
Hide resolved
caio-pizzol
left a comment
There was a problem hiding this comment.
solid fix - guard removal + explicit sync on undo/redo addresses the actual data flow gap (PR #2195 will prob conflict here)
…o-tracked-change-leaves-suggestion-bubble-side-panel
caio-pizzol
left a comment
There was a problem hiding this comment.
@palmer-cl no blocking issues. the comment id cleanup from last round looks good.
one thing: the isHistoryType check in PresentationEditor.ts is now a duplicate — left an inline comment. removing it also fixes the failing unit test.
tests look good. two nice-to-have behavior tests: one that redo brings the bubble back after undo removes it, and one that nothing happens when the document didn't actually change.
feel free to merge after addressing the comments.
packages/super-editor/src/core/presentation-editor/PresentationEditor.ts
Outdated
Show resolved
Hide resolved
|
🎉 This PR is included in superdoc v1.18.0-next.27 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.2.0-next.101 The release is available on GitHub release |