Skip to content

perf(comments): batch tracked change creation and virtualize floating bubbles (SD-1997) #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harbournick merged 6 commits into from
Feb 25, 2026
Merged

perf(comments): batch tracked change creation and virtualize floating bubbles (SD-1997) #2168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a76291e
perf(comments): virtualize floating comment bubbles with Intersection…
caio-pizzol Feb 25, 2026
74a1652
test(comments): add behavior tests for floating comment virtualization
caio-pizzol Feb 25, 2026
105dd30
chore: fix lockfile missing SDK optional dependency specifiers
caio-pizzol Feb 25, 2026
880f5d9
chore: ignore SDK scripts in eslint config
caio-pizzol Feb 25, 2026
8c2d48a
fix(comments): resolve activeComment key mismatch for imported Word c…
caio-pizzol Feb 25, 2026
7946bb9
fix(tests): update comment test selectors for virtualized FloatingCom…
caio-pizzol Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ export default [
'**/commitlint.config.js',
// E2E tests
'e2e-tests/**',
// SDK scripts — ESM parsed incorrectly by typescript-eslint
'packages/sdk/scripts/**',
],
},
{
Expand Down
8 changes: 5 additions & 3 deletions packages/superdoc/src/SuperDoc.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,11 +956,13 @@ watch(
},
);

// Ensure hasInitializedLocations is set when comments arrive (backup for cases
// where handleDocumentReady hasn't fired yet). Never toggle false→true→false —
// the virtualized FloatingComments reacts to comment changes via computed properties.
watch(getFloatingComments, () => {
hasInitializedLocations.value = false;
nextTick(() => {
if (!hasInitializedLocations.value) {
hasInitializedLocations.value = true;
});
}
});

const {
Expand Down
Loading
Loading