Skip to content

fix(comments): reduce sidebar jitter when clicking comments (SD-2034) #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caio-pizzol merged 2 commits into from
Mar 3, 2026
Merged

fix(comments): reduce sidebar jitter when clicking comments (SD-2034) #2250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ff629d
fix(comments): reduce sidebar jitter when clicking comments (SD-2034)
tupizz Mar 3, 2026
18e4a13
fix(comments): handle tall cards in scroll-to-comment visibility check
tupizz Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/superdoc/src/components/CommentsLayer/FloatingComments.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { useCommentsStore } from '@superdoc/stores/comments-store';
import { useSuperdocStore } from '@superdoc/stores/superdoc-store';
import CommentDialog from '@superdoc/components/CommentsLayer/CommentDialog.vue';

const ESTIMATED_HEIGHT = 80;
const ESTIMATED_HEIGHT = 110;
const OBSERVER_MARGIN = 600;

// Layout algorithm: positions comments in a single column with collision avoidance.
Expand Down Expand Up @@ -323,18 +323,23 @@ watch(activeComment, () => {
if (!key) return;

nextTick(() => {
// 400ms: wait for .comment-placeholder CSS transition (300ms) + buffer
scrollTimer = setTimeout(() => {
const el = placeholderRefs.value[key];
if (!el) return;

const rect = el.getBoundingClientRect();
const margin = 80;
const isVisible = rect.top >= margin && rect.top <= window.innerHeight - margin;
const availableHeight = window.innerHeight - 2 * margin;
const isVisible =
rect.height > availableHeight
? rect.top >= margin
: rect.top >= margin && rect.bottom <= window.innerHeight - margin;

if (!isVisible) {
el.scrollIntoView({ behavior: 'smooth', block: 'nearest' });
}
}, 100);
}, 400);
});
});

Expand Down Expand Up @@ -499,5 +504,7 @@ onBeforeUnmount(() => {
display: flex;
align-items: flex-start;
justify-content: flex-start;
/* SD-2034: smooth min-height changes to prevent scrollbar flash */
transition: min-height 0.5s ease-out;
}
</style>
Loading