fix(links): link styles should be removed when tracked change is rejected#2465
Conversation
superdoc-bot
Bot
added
review: thorough
review: careful
and removed
review: thorough
labels
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8289f71cdc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…jecting tracked changes
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@palmer-cl nice fix — removing "after" marks before restoring "before" marks is clean and the overlap matcher fills a real gap. no correctness issues. tests are solid across all layers. left a couple inline suggestions on duplicated code and one note on visual test coverage.
…ecting-a-hyperlink-tc-does-not-remove-the-hyperlink
Test-only utility was defined in the production documentHelpers module. Move it to @tests/helpers/helpers.js so it doesn't ship in the production bundle.
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@palmer-cl all three items from last round are done. pushed a commit moving a test-only helper out of production code.
looks good, approving.
caio-pizzol
deleted the
colep/sd-2251-bug-rejecting-a-hyperlink-tc-does-not-remove-the-hyperlink
branch
|
🎉 This PR is included in superdoc v1.22.0-next.14 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.1.0-next.14 |
|
🎉 This PR is included in superdoc-cli v0.4.0-next.14 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.22.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.1.0 |
|
🎉 This PR is included in superdoc-cli v0.4.0 The release is available on GitHub release |
|
🎉 This PR is included in esign v2.2.0-next.3 The release is available on GitHub release |
|
🎉 This PR is included in template-builder v1.3.0-next.2 The release is available on GitHub release |
3 participants
Fixed tracked-change reject for hyperlink suggestions so rejecting a suggested link removes both the link mark and transient hyperlink styling
Hardened layout invalidation by including hyperlink/underline/strike in diff and cache keys, so reject/apply formatting changes always trigger correct re-rendering instead of stale cached runs.