fix: hide image resize handles in view mode#2576
Conversation
VladaHarbour
force-pushed
the
sd-2323_hide-image-resize-view-mode
branch
from
d8efe78 to
409269e
Compare
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour looks good! tested in the dev app and the fix works — no resize handles or selection in viewing mode.
one small thing: the click handler hides the table overlay but forgets the image overlay, so stale handles can linger after a mode switch. left an inline comment.
pushed a commit with behavior tests (Word-native fixture + 3 Playwright tests).
VladaHarbour
force-pushed
the
sd-2323_hide-image-resize-view-mode
branch
from
21f6e2d to
d809f4e
Compare
Word-native test document with embedded image and three Playwright behavior tests: overlay hidden on hover in viewing mode, selection outline blocked on click in viewing mode, and overlay still works in editing mode (sanity check).
VladaHarbour
force-pushed
the
sd-2323_hide-image-resize-view-mode
branch
from
d809f4e to
fcdef97
Compare
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour looks good - the proactive cleanup on mode switch is a nice improvement over the first version.
pushed two small commits: fixed a missing field in the mode change event, and added unit tests for the resize overlay guard.
approving
caio-pizzol
force-pushed
the
sd-2323_hide-image-resize-view-mode
branch
from
bbac09a to
682e5d9
Compare
- PresentationEditor now emits { editor, documentMode } matching
the DocumentModeChangePayload type contract
- Add ImageResizeOverlay unit tests for the isResizeDisabled guard
(viewing mode, non-editable, and editing mode sanity check)
caio-pizzol
force-pushed
the
sd-2323_hide-image-resize-view-mode
branch
from
682e5d9 to
1fcdce8
Compare
|
🎉 This PR is included in esign v2.2.0-next.5 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v1.1.0-next.48 |
|
🎉 This PR is included in template-builder v1.3.0-next.4 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.24.0-next.45 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.5.0-next.45 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.3.0-next.45 |
|
🎉 This PR is included in superdoc v1.24.1 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.5.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.3.0 |
|
🎉 This PR is included in vscode-ext v2.2.0 |
2 participants
No description provided.