fix(math): propagate paragraph spacing to display math blocks (SD-2409)#2645
Conversation
|
Status: PASS The PR's OOXML changes are spec-compliant. Here's what I checked: Elements and attributes used:
Default value for One pre-existing issue worth noting (not introduced by this PR, but in the touched file): Line 15 of return jc.attributes['m:val'] || 'center';When |
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcaa575dea
βΉοΈ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
dcaa575 to
7b320c2
Compare
db80c1d to
cd9fa6a
Compare
cd9fa6a to
caa7458
Compare
|
π This PR is included in vscode-ext v1.1.0-next.50 |
|
π This PR is included in template-builder v1.3.0-next.6 The release is available on GitHub release |
|
π This PR is included in esign v2.2.0-next.7 The release is available on GitHub release |
|
π This PR is included in superdoc v1.24.0-next.47 The release is available on GitHub release |
|
π This PR is included in superdoc-cli v0.5.0-next.47 The release is available on GitHub release |
|
π This PR is included in superdoc-sdk v1.3.0-next.47 |
|
π This PR is included in superdoc v1.24.1 The release is available on GitHub release |
|
π This PR is included in superdoc-cli v0.5.0 The release is available on GitHub release |
|
π This PR is included in superdoc-sdk v1.3.0 |
|
π This PR is included in vscode-ext v2.2.0 |
Display math paragraphs (
m:oMathPara) were rendering with no vertical spacing β text and equations were cramped together. Word shows proper breathing room because the containingw:pparagraph's spacing properties apply.The root cause: when
mathBlockis hoisted out of its parentw:pduring import, the paragraph's spacing properties were dropped. The layout engine saw zero spacing.Fix: thread
paragraphPropertiesfrom the parentw:pthrough themathBlockPM node, then resolve them in the pm-adapter viacomputeParagraphAttrsβ same as regular paragraphs.paragraphPropertiesfromextraParamsonmathBlockattrsparagraphPropertiesattribute tomathBlockcomputeParagraphAttrsto resolve spacing, borders, indentSD-2409