Update presentation when typing inside table in sdt#2729
Conversation
superdoc-bot
Bot
added
review: thorough
review: careful
and removed
review: thorough
labels
VladaHarbour
force-pushed
the
sd-2453_typing-table-sdt
branch
from
1964a88 to
006066c
Compare
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour good fix — the three changes work well together: cache updates so edits show up, version tracking so the page re-renders, and click handling so the cursor lands inside the inner table instead of selecting the whole field.
no correctness issues found.
one thing we noticed while testing: opening a Word file that already has this structure (table inside an SDT inside a table cell) doesn't produce the right nodes on import — the inner tables get dropped. that's not something this PR broke, it was already like that, but it means these code paths only get triggered through the template builder (where users build the structure interactively). could be worth a follow-up ticket for import support.
left two inline comments — both about test coverage, not the logic itself.
VladaHarbour
force-pushed
the
sd-2453_typing-table-sdt
branch
from
006066c to
82075ec
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.19 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.3.0-next.22 |
|
🎉 This PR is included in template-builder v1.5.0-next.22 The release is available on GitHub release |
|
🎉 This PR is included in esign v2.3.0-next.22 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.26.0-next.22 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.7.0-next.23 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.6.0-next.20 |
|
🎉 This PR is included in superdoc-cli v0.7.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.27.0 The release is available on GitHub release |
|
🎉 This PR is included in @superdoc-dev/react v1.2.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.6.0 |
5 participants
No description provided.