fix: comment bubble got cut off#2756
Conversation
VladaHarbour
force-pushed
the
sd-2464_comment-bubble-cut-off
branch
from
4f4c1ef to
009a695
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f4c1ef84c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour fix works well with a few bubbles, but with 7+ tracked changes on a short doc, the last bubble still gets clipped — reproduced it locally. the sidebar shifts up in that case and the height fix doesn't apply. root issue is overflow: hidden on .floating-comments in SuperDoc.vue. left inline comments.
VladaHarbour
force-pushed
the
sd-2464_comment-bubble-cut-off
branch
from
6f4a8be to
595fa34
Compare
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour both issues from last round are fixed. verified locally that bubbles show fully even with many tracked changes. nice work.
Behavior test that creates 8+ tracked changes, clicks the last bubble, and asserts the sidebar uses overflow: visible so bubbles are never clipped by the parent container.
|
🎉 This PR is included in vscode-ext v1.1.0-next.73 |
|
🎉 This PR is included in @superdoc-dev/react v1.0.0-next.27 The release is available on GitHub release |
|
🎉 This PR is included in esign v2.2.0-next.31 The release is available on GitHub release |
|
🎉 This PR is included in template-builder v1.3.0-next.33 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.24.0-next.70 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.5.0-next.71 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.3.0-next.72 |
|
🎉 This PR is included in superdoc-sdk v1.4.0 |
|
🎉 This PR is included in superdoc v1.25.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.6.0 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.3.0-next.1 |
|
🎉 This PR is included in template-builder v1.5.0-next.1 The release is available on GitHub release |
|
🎉 This PR is included in esign v2.3.0-next.1 The release is available on GitHub release |
2 participants
No description provided.