refactor(layout): lift fragment metadata into resolved paint items#2811
Open
tupizz wants to merge 1 commit intotadeu/sd-2563-01-page-metadatafrom
Open
refactor(layout): lift fragment metadata into resolved paint items#2811tupizz wants to merge 1 commit intotadeu/sd-2563-01-page-metadatafrom
tupizz wants to merge 1 commit intotadeu/sd-2563-01-page-metadatafrom
Conversation
Add pmStart, pmEnd, continuesFromPrev, continuesOnNext, markerWidth, and metadata fields to resolved paint item types. Populate them in the resolvers and update the painter to prefer resolved item data over legacy Fragment reads with fallbacks.
3 tasks
superdoc-bot
bot
added
review: thorough
review: careful
and removed
review: thorough
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pmStart,pmEnd,continuesFromPrev,continuesOnNext,markerWidthto resolved itemsmetadatatoResolvedImageItemPR Stack (SD-2563: Dumb Painter Refactor)
Test plan