fix(test): scope m:nary supHide assertion to operator wrapper#2833
Merged
caio-pizzol merged 1 commit intomainfrom Apr 16, 2026
Merged
fix(test): scope m:nary supHide assertion to operator wrapper#2833caio-pizzol merged 1 commit intomainfrom
caio-pizzol merged 1 commit intomainfrom
Conversation
The union-with-supHide assertion checked for any <msub> in the whole <math> element, but the scenario 6 fixture body contains <m:sSub> (Aᵢ), which legitimately renders as <msub>. That made the test fail on every run since it landed. Assert on the n-ary's own wrapper (the parent of <mo>⋃</mo>) instead, which is what the test was actually trying to verify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behavior test
math-equations.spec.ts:951("union with supHide renders as ") has been failing on main and every PR since it landed in #2752. The converter is correct — the test assertion was overly broad.math-nary-tests.docxhas<m:sSub>(Aᵢ) in the n-ary body<m:e>, which legitimately renders as<msub>via the m:sSub converter (feat(math): implement m:sSub subscript converter (SD-2373) #2635).math.querySelector('msub') !== nullpicked up that body<msub>, not the n-ary's own wrapper choice, so it always failed.<mo>⋃</mo>and checks its parent tag is<munder>— which is what the test actually intends to verify.