test(superdoc): tighten assertions + adjust codecov policy#2841
test(superdoc): tighten assertions + adjust codecov policy#2841caio-pizzol merged 1 commit intomainfrom
Conversation
Follow-up to the coverage push, addressing feedback from an external review of the new test suite. - Replace tautological assertions (expect(true).toBe(true)) and does-not-throw placeholders with observable-state assertions on the Delete-keydown-from-input branch and image reconciliation - Fix window keydown listener leak in WhiteboardPage-deep tests by destroying mounted pages in afterEach - Rewrite the "clicking an image selects it" test to assert the selection overlay was attached to the visible layer, not just that the Transformer constructor was invoked - Trim create-app-edges from 7 queue-mechanics tests to 4 outcome tests; the suite now survives refactors of the suppression strategy - Migrate setTimeout(r, 0) microtask flushing to await Promise.resolve() codecov.yml: set project and patch targets to 90% (from auto). Avoids the coverage-gaming incentives of a 95% project target on a UI-heavy library and sets a sustainable bar for new code.
caio-pizzol
force-pushed
the
caio/superdoc-coverage-cleanup
branch
from
939540b to
42a878e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.17 The release is available on GitHub release |
|
🎉 This PR is included in esign v2.3.0-next.20 The release is available on GitHub release |
|
🎉 This PR is included in template-builder v1.5.0-next.20 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.3.0-next.20 |
|
🎉 This PR is included in superdoc-cli v0.7.0-next.21 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.26.0-next.20 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.6.0-next.18 |
|
🎉 This PR is included in superdoc-cli v0.7.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.27.0 The release is available on GitHub release |
|
🎉 This PR is included in @superdoc-dev/react v1.2.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.6.0 |
2 participants
Follow-up to #2840, addressing review feedback from an external consultation of the new test suite.
This PR stacks on top of #2840 — please merge #2840 first, then rebase this on main.
expect(true).toBe(true)) and does-not-throw placeholders with observable-state assertionssetTimeout(r, 0)microtask flushing toawait Promise.resolve()auto) — avoids coverage-gaming incentives and sets a sustainable bar for new codeCoverage: 91.48% (vs 91.52% on #2840 — 0.04pp drop from trimming 3 implementation-detail tests, a deliberate trade for better test quality). All tests pass.