fix: applying formatting to header/footer#2904
Merged
harbournick merged 2 commits intomainfrom Apr 22, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.41 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in vscode-ext v2.3.0-next.43 |
Contributor
|
🎉 This PR is included in template-builder v1.6.0-next.6 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in esign v2.3.0-next.43 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc v1.28.0-next.6 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-cli v0.8.0-next.6 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-sdk v1.6.0-next.42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: SD-2618
Fixes inconsistent toolbar formatting in header/footer by removing stale selection restoration and avoiding deferred mark execution in H/F.
What changed
restoreSelection()for header/footer toolbar interactions.pendingMarkCommandsqueue).tr.selection) via a centralized helper.restoreSelectioncall in header/footer toolbar flow,Result
bold/italic/underline/color/highlightnow apply immediately in centered header/footer text.fontFamily/fontSizenow apply immediately without requiring an extra selection change.