list tool improvements#2927
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
…mbol font violations - Introduced `numbering-consistency.js` to validate that ordered list levels do not use symbol fonts, preventing rendering issues in Word. - Implemented `findSymbolFontsOnOrderedLevels` function to identify violations in OOXML abstractNum elements. - Added comprehensive tests in `numbering-consistency.test.js` to ensure correct functionality and edge case handling.
- Updated `package.json` to refine the `clean` script and introduce new prebuild commands for benchmark dependencies. - Added a new function `usesListAction` in `checks.cjs` to validate that the expected list action is called during evaluations. - Introduced a new document `basic-list.docx` for testing list operations. - Expanded benchmark and execution tests to include assertions for list actions, ensuring correct functionality for merging, splitting, and restarting lists. - Implemented regression guards to check for symbol font violations in ordered lists.
…d-numbering-workflow-targeting
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 600960f430
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…s and improve readability
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
hey @andrii-harbour! nice direction - merge and split fill a real gap.
two bugs to fix before merge, both inline. would also add dry-run tests for the new ops.
- Updated test descriptions for clarity, removing references to specific bugs. - Added new test cases for `lists.merge` and `lists.split` actions to ensure proper functionality and validation. - Refactored `listsMergeWrapper` and `listsSplitWrapper` to improve handling of empty paragraphs and revision management during list operations.
…d-numbering-workflow-targeting
|
@caio-pizzol fixed |
Adds checkBulletsAndNumbersMerged, checkBulletListSplitAtWith, and checkRestartAtAllSorts in evals/shared/checks.cjs that read word/document.xml from the saved docx and verify the numId/ilvl change the agent was supposed to make. Without these the merge/split/restart evals could pass even if the list itself never changed. Also reword the listsSplitWrapper doc comment to drop the misleading "applied atomically" claim - the implementation runs as two sequential steps and the inline note already documents the partial-apply failure mode. And rename the validator test that read backwards (default is restart-on, not opt-out).
|
hey @andrii-harbour! nice paraId fix. i pushed a follow-up (1924ca8): fixed the split comment that promised atomic but the code runs in two steps, renamed the test that read backwards, and added checks so the merge/split/restart evals fail when the list doesn't actually change. lgtm |
…d-numbering-workflow-targeting
caio-pizzol
deleted the
andrii/sd-2296-tool-improvements-fix-list-and-numbering-workflow-targeting
branch
|
🎉 This PR is included in superdoc v1.30.0-next.6 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.8.0-next.6 |
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.4 The release is available on GitHub release |
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.49 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.3.0-next.51 |
|
🎉 This PR is included in superdoc v1.30.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.8.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.8.0 |
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.3.0 |
|
🎉 This PR is included in @superdoc-dev/react v1.3.0 The release is available on GitHub release |
3 participants
No description provided.