Skip to content

fix: sdt field style#2958

Merged
caio-pizzol merged 1 commit into
mainfrom
artem/SD-2744
Apr 28, 2026
Merged

fix: sdt field style#2958
caio-pizzol merged 1 commit into
mainfrom
artem/SD-2744

Conversation

@artem-harbour
Copy link
Copy Markdown
Contributor

@artem-harbour artem-harbour commented Apr 27, 2026

Linear: SD-2744

Fix inline SDT outline collapse in Template Builder after superdoc@1.28 strut update.

  • Root cause: line containers now use font-size: 0; inline SDT wrappers inherited collapsed metrics, so borders rendered as a thin sliver.
  • Change: restore and continuously sync inline SDT wrapper typography from current run font size (with fallback), in both geometry and run-based render paths.
  • Result: SDT borders correctly wrap text and stay in sync when field text font-size changes.

Before
Screenshot 2026-04-27 at 17 40 23

After
Screenshot 2026-04-27 at 17 41 23

@linear
Copy link
Copy Markdown

linear Bot commented Apr 27, 2026

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 417ecd8110

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/layout-engine/painters/dom/src/renderer.ts
Copy link
Copy Markdown
Contributor

@caio-pizzol caio-pizzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @artem-harbour! good call, this fixes the sliver cleanly :)

approving, feel free to merge after addressing whatever feels relevant.

side note: nothing in our test suite caught the original 1.28 sliver. worth adding sdts-basic.docx to the visual tests as a follow-up.

Comment thread packages/layout-engine/painters/dom/src/renderer.ts Outdated
Comment thread packages/layout-engine/painters/dom/src/renderer.ts Outdated
Comment thread packages/layout-engine/painters/dom/src/index.test.ts
@artem-harbour artem-harbour added this pull request to the merge queue Apr 28, 2026
@artem-harbour artem-harbour removed this pull request from the merge queue due to a manual request Apr 28, 2026
@caio-pizzol caio-pizzol added this pull request to the merge queue Apr 28, 2026
Merged via the queue into main with commit d54519c Apr 28, 2026
55 checks passed
@caio-pizzol caio-pizzol deleted the artem/SD-2744 branch April 28, 2026 17:40
@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 28, 2026

🎉 This PR is included in superdoc v1.30.0-next.6

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 28, 2026

🎉 This PR is included in superdoc-sdk v1.8.0-next.6

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 28, 2026

🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.4

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 29, 2026

🎉 This PR is included in @superdoc-dev/react v1.2.0-next.49

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 29, 2026

🎉 This PR is included in vscode-ext v2.3.0-next.51

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 30, 2026

🎉 This PR is included in superdoc v1.30.0

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 1, 2026

🎉 This PR is included in superdoc-cli v0.8.0

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 1, 2026

🎉 This PR is included in superdoc-sdk v1.8.0

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 1, 2026

🎉 This PR is included in @superdoc-dev/mcp v0.3.0

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 5, 2026

🎉 This PR is included in vscode-ext v2.3.0

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 7, 2026

🎉 This PR is included in @superdoc-dev/react v1.3.0

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants