fix: footer tcs in replacement generating one per character#2965
Merged
harbournick merged 2 commits intomainfrom Apr 27, 2026
Merged
Conversation
superdoc-bot
Bot
added
review: thorough
review: careful
and removed
review: thorough
labels
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96fa08f017
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
harbournick
deleted the
nick/sd-2732-tracked-changes-in-headers-footers-feedback-round-3
branch
chittolinag
pushed a commit
that referenced
this pull request
Apr 29, 2026
* fix: footer tcs in replacement generating one per character
luccas-harbour
added a commit
that referenced
this pull request
Apr 29, 2026
…le) (#2857) * feat: implement 2 extra types of bullet lists (square, circle) * refactor: code reuse * refactor: simplified code removing font override * chore: small code tweaks * test: add coverage for bullet style picker (SD-2526) unit: - numbering-transforms.test.ts (new): generateNewListDefinition with bulletStyle, lvlText override, rFonts strip, ordered-list ignore - list-numbering-helpers.test.js: markerTextToBulletStyle truth table + null cases - toggleList.test.js: style-aware predicate, swap-mints-numId path, no-arg fallback - create-headless-toolbar.test.ts: bullet-list direct command forwards style argument - toolbar-registry.test.ts: bullet-list state exposes raw markerText for each style behavior (playwright): - bullet-style-picker.spec.ts: AC1, AC2, AC3, AC5 picker UX + active-style reflection - bullet-style-undo-redo.spec.ts: AC9 undo of initial create - bullet-style-word-fixtures.spec.ts: round-trip from real Word disc/circle/square docs (fixtures generated via Word COM) * test(lists): verify bullet style export round-trips to DOCX Adds a behavior test that picks bullet styles via the toolbar dropdown, then exports and inspects numbering.xml to confirm the per-list w:lvlText markers match the chosen disc/square styles. * fix: footer tcs in replacement generating one per character (#2965) * fix: footer tcs in replacement generating one per character * feat: added split button for button styles * fix: generate new nsid when list style is changed * fix: changing list style changes current identation * fix: list item de-indentation * fix: lockfile * chore: removed console log --------- Co-authored-by: Gabriel Chittolina <gabrielchittolina1@gmail.com> Co-authored-by: Caio Pizzol <caio@superdoc.dev> Co-authored-by: Luccas Correa <luccas@harbourshare.com> Co-authored-by: Nick Bernal <117235294+harbournick@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.