HAR-7108 - SuperDoc docx editor (super editor) package#3
Closed
harbournick wants to merge 3 commits intomainfrom
Closed
HAR-7108 - SuperDoc docx editor (super editor) package#3harbournick wants to merge 3 commits intomainfrom
harbournick wants to merge 3 commits intomainfrom
Conversation
tupizz
added a commit
that referenced
this pull request
Apr 16, 2026
…nt tests Applies testing-excellence principles to the SD-2563 test suite: 1. Remove dead mock stubs (Iron Law #3: never mock what you don't understand). 11 test files carried vi.mock('@superdoc/layout-resolved') stubs that no test depends on — PresentationEditor imports the module, but these tests don't exercise paths that call it. Verified by removing and running the full suite: all 11348 tests pass without the stubs. 2. Kept the stubs in 2 files whose tests genuinely depend on controlled resolveLayout behavior (PresentationEditor.footnotesPmMarkers and PresentationEditor.sectionPageStyles). 3. Added HeaderFooterSessionManager.alignment.test.ts covering the two previously-untested risk areas: - rId-based path delivers items aligned 1:1 with fragments (multi-section documents — uses real resolveHeaderFooterLayout) - Length-mismatch guard drops items and emits a warning when resolved and fragment counts diverge (proves the runtime safety net works) Net: -44 lines of dead mock boilerplate, +190 lines of real test coverage. Total super-editor tests: 11348 -> 11350.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.