Skip to content

fix(super-editor/ui): cast TextTarget through unknown for story lookup#3020

Merged
caio-pizzol merged 1 commit into
mainfrom
caio-pizzol/fix-textTarget-story-cast
Apr 29, 2026
Merged

fix(super-editor/ui): cast TextTarget through unknown for story lookup#3020
caio-pizzol merged 1 commit into
mainfrom
caio-pizzol/fix-textTarget-story-cast

Conversation

@caio-pizzol
Copy link
Copy Markdown
Contributor

The release build's type-check fails with TS2352 because TextTarget doesn't sufficiently overlap with { story?: Record<string, unknown> }. Casting through unknown first satisfies the compiler without changing runtime behavior.

Failing job: https://github.com/superdoc-dev/superdoc/actions/runs/25137297898/job/73678726322

Verified: pnpm run type-check → exit 0

TS2352 in CI: TextTarget doesn't sufficiently overlap with { story?: Record<string, unknown> }, so cast via unknown first.
@caio-pizzol caio-pizzol requested a review from a team as a code owner April 29, 2026 22:40
@caio-pizzol caio-pizzol merged commit a873ed9 into main Apr 29, 2026
46 checks passed
@caio-pizzol caio-pizzol deleted the caio-pizzol/fix-textTarget-story-cast branch April 29, 2026 22:43
@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 29, 2026

🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.14

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 29, 2026

🎉 This PR is included in vscode-ext v2.3.0-next.59

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 29, 2026

🎉 This PR is included in @superdoc-dev/react v1.2.0-next.57

The release is available on GitHub release

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 29, 2026

🎉 This PR is included in superdoc v1.30.0-next.17

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 29, 2026

🎉 This PR is included in superdoc-cli v0.8.0-next.32

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 29, 2026

🎉 This PR is included in superdoc-sdk v1.8.0-next.18

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented Apr 30, 2026

🎉 This PR is included in superdoc v1.30.0

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 1, 2026

🎉 This PR is included in superdoc-cli v0.8.0

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 1, 2026

🎉 This PR is included in superdoc-sdk v1.8.0

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 1, 2026

🎉 This PR is included in @superdoc-dev/mcp v0.3.0

The release is available on GitHub release

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 5, 2026

🎉 This PR is included in vscode-ext v2.3.0

@superdoc-bot
Copy link
Copy Markdown
Contributor

superdoc-bot Bot commented May 7, 2026

🎉 This PR is included in @superdoc-dev/react v1.3.0

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants