docs(contributing): name the public-API type-test rule (SD-2862)#3042
Merged
Conversation
The auto-derive script (SD-2860) and the subpath matrix (SD-2861) are now the regression net for public exports, but the rule that PRs adding public exports must keep them green was implicit. Make it explicit in CONTRIBUTING.md so contributors know which gates apply and how to run them, and add a checkbox to the "Before Submitting" list. The enforcement is unchanged; this is the documentation that names it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auto-derive script from SD-2860 and the subpath matrix from SD-2861 are the regression net for public exports. The rule "PRs adding public exports must keep these gates green" was implicit until now. Make it explicit so contributors know which gates apply and how to regenerate the assertion list.
The enforcement is unchanged. This is the documentation that names it: a new H3 in
Pull Request Processand an entry in theBefore Submittingchecklist that points back to it.