Skip to content

Telemetry v1 updates#305

Merged
caio-pizzol merged 4 commits into
mainfrom
telemetry_v1
Feb 21, 2025
Merged

Telemetry v1 updates#305
caio-pizzol merged 4 commits into
mainfrom
telemetry_v1

Conversation

@VladaHarbour

Copy link
Copy Markdown
Contributor

No description provided.

@VladaHarbour VladaHarbour self-assigned this Feb 19, 2025
Comment thread shared/common/Telemetry.js Fixed

@caio-pizzol caio-pizzol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VladaHarbour overall LGTM - just a few comments.
@harbournick @artem-harbour want to hear your thoughts as well.

Comment thread packages/super-editor/src/core/super-converter/SuperConverter.js Outdated
Comment thread shared/common/Telemetry.js
Comment thread shared/common/Telemetry.js
Comment thread packages/super-editor/src/core/super-converter/v2/importer/docxImporter.js Outdated

@caio-pizzol caio-pizzol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caio-pizzol caio-pizzol merged commit 1eefeec into main Feb 21, 2025
@caio-pizzol caio-pizzol deleted the telemetry_v1 branch February 21, 2025 15:07
superdoc-bot Bot pushed a commit that referenced this pull request Jul 3, 2026
…changes (SD-3563) (#305)

* fix(super-editor): export tracked citation hyperlinks

SD-3563 fixes v1 headless structural insertion of citation hyperlinks when track changes are enabled.

The structural writer already materialized linked citation text with both link and trackInsert marks, but DOCX export prioritized the track-change wrapper and paragraph merge could emit a single w:ins around both linked and unlinked text. That lost the valid tracked-hyperlink shape Bloomberg needs for reviewable citations.

Text export now routes linked tracked text through the hyperlink translator first so DOCX emits w:hyperlink containing w:ins/w:del content. Hyperlink export preserves remaining revision marks while stripping only the link mark, and hyperlink import now includes revision children so w:hyperlink > w:ins/w:del round-trips back to linked tracked text.

Adds SD-3563 regression coverage for the v1 headless plan flow plus focused translator tests for linked tracked export/import.

* fix(super-editor): drop final linked deletions

* fix: tracked hyperlink rejection cleanup

Ported-From-Source-Repo: superdoc/orbit
Ported-From-Source-Commit: 8a0951df3b15045bf47390e82ca24e5714aa9f1d
Ported-Public-Prefix: superdoc/public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants