ci(superdoc): enroll use-password-prompt.js under checkJs gate (SD-2866)#3050
ci(superdoc): enroll use-password-prompt.js under checkJs gate (SD-2866)#3050caio-pizzol merged 1 commit intomainfrom
Conversation
superdoc-bot
Bot
added
review: thorough
review: quick
and removed
review: thorough
labels
Third file under the SD-2863 ratchet. Closes 8 errors that the probe
surfaced:
- The internal queue's element type lacked the `originalException`
field that handleEncryptionError pushes onto each entry. Real drift:
the JSDoc said `{ doc, errorCode }` but the runtime stored
`{ doc, errorCode, originalException }` and the value was read again
in onUnhandled. Promoted to a named QueueEntry typedef with the
field properly declared.
- queue.shift() returns undefined when empty; added a fast-path early
return after the shift so the rest of the function can rely on a
defined entry.
- The lazy import of PasswordPromptSurface.vue now goes through the
*.vue ambient shim added in SD-2865 and casts the default export to
object before passing to markRaw().
Stacks on caio/SD-2865-checkjs-find-replace because SD-2865 introduced
the *.vue shim.
caio-pizzol
force-pushed
the
caio/SD-2866-checkjs-password-prompt
branch
from
9350891 to
832eb74
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.29 The release is available on GitHub release |
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.72 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.3.0-next.74 |
|
🎉 This PR is included in superdoc v1.30.0-next.31 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.8.0-next.47 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.8.0-next.33 |
|
🎉 This PR is included in superdoc-cli v0.8.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.8.0 |
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.31.0 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.3.0 |
|
🎉 This PR is included in @superdoc-dev/react v1.3.0 The release is available on GitHub release |
2 participants
Third file under the SD-2863 ratchet. Stacked on #3048 because SD-2865 introduced the `*.vue` ambient shim that this PR also relies on; will rebase to main after #3048 merges.
The probe surfaced 8 errors. Closes them by:
Verified: `pnpm --filter superdoc run check:jsdoc` reports 3 gated files clean. The `use-password-prompt` test suite (35 tests) passes.