fix(super-editor): re-export ContentControlViewportAddress and ViewportEntityAddress (SD-3156)#3316
Merged
Merged
Conversation
…rtEntityAddress (SD-3156) The public `superdoc/ui` barrel (`packages/superdoc/src/ui.d.ts`) imports both names from `@superdoc/super-editor/ui`, but they were missing from `packages/super-editor/src/ui/index.ts`. The existing `ui.barrel.test.ts` only string-scans the barrel file, so it didn't catch the upstream gap. CI's consumer-typecheck matrix (`bundler | node16 | nodenext` with `skipLibCheck=false`) was failing with TS2305 on both names since #3310 landed.
Contributor
|
🎉 This PR is included in vscode-ext v2.3.0-next.149 |
Contributor
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.103 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.147 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-cli v0.8.0-next.118 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-sdk v1.8.0-next.101 |
Contributor
|
🎉 This PR is included in superdoc v1.30.0-next.97 The release is available on GitHub release |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-exports two viewport-address types from
@superdoc/super-editor/uithat #3310 (SD-3156) added to the package internals and to thesuperdoc/uipublic barrel, but forgot to wire through the upstream module.packages/superdoc/src/ui.d.tsalready listsContentControlViewportAddressandViewportEntityAddressas re-exports from@superdoc/super-editor/ui, butpackages/super-editor/src/ui/index.tsdid not export them. The existingui.barrel.test.tsonly string-scans the barrel file for the names, so it passed even though the names didn't resolve. The consumer-typecheck matrix (bundler | node16 | nodenextwithskipLibCheck=false) is the one that actually compiles the public surface and has been failing withTS2305: Module ... has no exported membersince #3310 landed.Verified locally:
cd tests/consumer-typecheck && node typecheck-matrix.mjsnow reports 57 passed, 0 failed. The three scenarios that were failing in CI (*/all public surface / skipLibCheck=false) all pass.Verified:
node tests/consumer-typecheck/typecheck-matrix.mjs→ 57 passed, 0 failed;pnpm --filter @superdoc/super-editor test→ 12964 passed.