feat(toolbar): make formatting marks button opt-in via config#3324
Conversation
superdoc-bot
Bot
added
review: thorough
review: quick
and removed
review: thorough
labels
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f405635535
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| toolbarItems.splice(getLinkedStylesIndex - 1, 2); | ||
|
|
||
| const filterItems = ['ruler', 'formattingMarks', 'zoom', 'undo', 'redo']; | ||
| const filterItems = ['ruler', 'zoom', 'undo', 'redo']; |
There was a problem hiding this comment.
When showFormattingMarksButton is enabled for a toolbar running with config.mode !== 'docx' (for example an html/text Editor toolbar, which the new test now expects), this filter no longer removes the pilcrow button even though the command is only implemented through SuperDoc's layout/presentation rendering path. In standalone SuperToolbar({ editor }) there is no superdoc.toggleFormattingMarks, so clicking falls through to a missing editor command and throws; in SuperDoc HTML documents the viewer is the plain HtmlViewer rather than a PresentationEditor, so toggling has no rendered effect. Please keep this item filtered for non-docx modes or gate it on an available formatting-marks implementation.
Useful? React with 👍 / 👎.
|
🎉 This PR is included in @superdoc-dev/mcp v0.3.0-next.107 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.3.0-next.153 |
|
🎉 This PR is included in @superdoc-dev/react v1.2.0-next.151 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.8.0-next.122 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.8.0-next.105 |
|
🎉 This PR is included in superdoc v1.30.0-next.101 The release is available on GitHub release |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2 participants
The pilcrow (¶) button is now opt-in instead of shipping in the default toolbar. Consumers that want it back set
modules.toolbar.showFormattingMarksButton: true.superdoc.toggleFormattingMarks()command andlayoutEngineOptions.showFormattingMarkspaint option are unchanged.layoutEngineOptions.showFormattingMarksto avoid name collision. The layout option controls whether marks render in the document; the toolbar flag only controls the button's presence.formattingMarksfrom the non-docx filter since the behavior is paint-side, not converter state.Verified:
pnpm --filter @superdoc/super-editor test src/editors/v1/components/toolbar/91/91 passing;pnpm --filter superdoc... buildclean.