Skip to content

fix: align column test fixtures#3668

Merged
caio-pizzol merged 1 commit into
mainfrom
caio-pizzol/sd-2629-column-test-fixtures
Jun 6, 2026
Merged

fix: align column test fixtures#3668
caio-pizzol merged 1 commit into
mainfrom
caio-pizzol/sd-2629-column-test-fixtures

Conversation

@caio-pizzol
Copy link
Copy Markdown
Contributor

@caio-pizzol caio-pizzol commented Jun 5, 2026

Fixes a stale SD-2629 layout-engine Bun test expectation left after the explicit-column no-scale geometry flip.

Root cause:

  • Current column geometry preserves authored explicit widths. For the test case, the second column starts at 50 + 100 + 48 = 198.
  • The test still computed the old scaled-width position and expected 198.8, so unit-tests (other-packages) failed in the Bun test step.

What changed:

  • Updated the layout-engine test to expect the authored-width column position.

Context:

  • The earlier clickToPosition and columnRegions fixture fixes are already present on current main, so this branch now only carries the remaining layout-engine expectation.

Checks:

  • pnpm install --frozen-lockfile --ignore-scripts
  • pnpm exec prettier --check packages/layout-engine/layout-engine/src/index.test.ts
  • git diff --check
  • Lefthook pre-commit: check-dts-shadows, format, lint

Local unit tests were not run because this repo forbids local unit test runs. CI should run the affected Bun path.

@linear-code
Copy link
Copy Markdown

linear-code Bot commented Jun 5, 2026

SD-2629

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@caio-pizzol caio-pizzol force-pushed the caio-pizzol/sd-2629-column-test-fixtures branch from 594bb1d to 6530315 Compare June 5, 2026 23:44
@caio-pizzol caio-pizzol marked this pull request as ready for review June 6, 2026 00:09
@caio-pizzol caio-pizzol requested a review from a team as a code owner June 6, 2026 00:09
@caio-pizzol caio-pizzol merged commit a96e918 into main Jun 6, 2026
68 checks passed
@caio-pizzol caio-pizzol deleted the caio-pizzol/sd-2629-column-test-fixtures branch June 6, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants