fix: align column test fixtures#3668
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
594bb1d to
6530315
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a stale SD-2629 layout-engine Bun test expectation left after the explicit-column no-scale geometry flip.
Root cause:
50 + 100 + 48 = 198.198.8, sounit-tests (other-packages)failed in the Bun test step.What changed:
Context:
clickToPositionandcolumnRegionsfixture fixes are already present on currentmain, so this branch now only carries the remaining layout-engine expectation.Checks:
pnpm install --frozen-lockfile --ignore-scriptspnpm exec prettier --check packages/layout-engine/layout-engine/src/index.test.tsgit diff --checkcheck-dts-shadows, format, lintLocal unit tests were not run because this repo forbids local unit test runs. CI should run the affected Bun path.