chore(font-system): upgrade @docfonts/fallbacks to 0.3.0#3671
Merged
Conversation
Pin the font-system to the face-scope-safe docfonts release. 0.3.0 adds the face-aware lookups (getRenderableFallbackForFace / getFallbackDecisionForFace), a faces field on every result, and the category-fallback face fix - all additive. The vendored wrapper and the resolver are unchanged: the resolver reads only policyAction/substituteFamily from getRenderableFallback (same at 0.3.0), and the SUBSTITUTION_EVIDENCE data-row shape is unchanged so the drift-guard const still compiles. No behavior change. resolveFace stays face-safe via runtime hasFace, which is more accurate than the package's static faces; this just makes 0.3.0 the baseline so a future Regular-only bundled substitute is handled correctly.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins
@superdoc/font-systemto the face-scope-safe docfonts release. The integration itself already happened (the vendored evidence is a wrapper over@docfonts/fallbacks, the resolver derives asset-gated maps from it); this is just the version bump to 0.3.0.0.3.0 is additive for SuperDoc: it adds the face-aware lookups, a
facesfield on every result, and the category-fallback face fix. SuperDoc reads onlypolicyAction/substituteFamilyoffgetRenderableFallback(unchanged at 0.3.0), and theSUBSTITUTION_EVIDENCEdata-row shape is unchanged, so the drift-guardconstinsubstitution-evidence.tsstill compiles. No behavior change.One deliberate call worth flagging: I did not switch
resolveFacetogetFallbackDecisionForFace, even though that helper now exists.#resolveFaceLadderis already face-safe via runtimehasFace- a bundled substitute applies only whenhasFace(bundled, weight, style), so a Regular-only substitute asked for bold already falls through tofallback_face_absent. The live FontFaceSet is more accurate than the package's staticfacesdata, so delegating to the package helper would be a step back. The 0.3.0 helper stays available for the later verdict-aware reporting pass (per-face verdicts), which is out of scope here.Net effect: makes 0.3.0 the baseline so a future Regular-only bundled substitute (e.g. Caprasimo for Cooper Black) is handled correctly with no further resolver change.
Lockfile diff is scoped to the one dependency (integrity verified against npm); no other versions churned.