Skip to content

HAR-9411 - optimize pdf viewer#449

Merged
harbournick merged 1 commit intomainfrom
artem-HAR-9411-v2
Apr 8, 2025
Merged

HAR-9411 - optimize pdf viewer#449
harbournick merged 1 commit intomainfrom
artem-HAR-9411-v2

Conversation

@artem-harbour
Copy link
Copy Markdown
Contributor

@artem-harbour artem-harbour commented Apr 8, 2025 •
edited
Loading

  • PDF text layer is optional and can be enabled/disabled via config.
  • Call necessary destroy methods.
  • Call URL.revokeObjectURL on the worker otherwise a new worker is created each time (and the old one is not destroyed).
  • Fix SD destroy method to unmount the app.
  • Other minor improvements.

@artem-harbour artem-harbour self-assigned this Apr 8, 2025
@artem-harbour artem-harbour force-pushed the artem-HAR-9411-v2 branch 2 times, most recently from 61a7d74 to 5a2b13c Compare April 8, 2025 15:42
@artem-harbour artem-harbour marked this pull request as ready for review April 8, 2025 16:55
harbournick
harbournick approved these changes Apr 8, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick merged commit 9462857 into main Apr 8, 2025
6 checks passed
@harbournick harbournick deleted the artem-HAR-9411-v2 branch April 8, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harbournick harbournick harbournick approved these changes

Assignees

@artem-harbour artem-harbour

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artem-harbour @harbournick