Skip to content

HAR-8863 - Lists v1#458

Merged
edoversb merged 4 commits into
mainfrom
nick/har-8863-lists-v1
Apr 15, 2025
Merged

HAR-8863 - Lists v1#458
edoversb merged 4 commits into
mainfrom
nick/har-8863-lists-v1

Conversation

@harbournick
Copy link
Copy Markdown
Collaborator

@harbournick harbournick commented Apr 15, 2025

Next iteration of lists import/export/rendering

  • Fixes many issues around lists that are broken by other block nodes (ie: paragraph, table)
  • Fixes sublists that are broken by other block nodes (ie: paragraph, table)
  • adds import list tracking for list continuity
  • adds list definitions from styles.xml
  • adds 24 more tests (27% increase) all around import/export of lists]
  • adds framework for testing list editor commands (to test generated lists, plus export)

@harbournick harbournick self-assigned this Apr 15, 2025
import { isIOS } from '../utilities/isIOS.js';
import { isMacOS } from '../utilities/isMacOS.js';

export const handleEnter = (editor) => {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: separating these into exported functions allows us to call these from inside our unit tests, therefore allowing us to easily edit test docs and test at each stage (ie: add list, add another node, hit enter, hit enter, add another list item, export the whole thing, test the export)

Copy link
Copy Markdown
Contributor

@edoversb edoversb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edoversb edoversb merged commit e960bc2 into main Apr 15, 2025
5 of 6 checks passed
@edoversb edoversb deleted the nick/har-8863-lists-v1 branch April 15, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants