Skip to content

HAR-10096 Strikethrough toolbar item#656

Merged
edoversb merged 2 commits intodevelopfrom
har-10096_strikethrough-toolbar
Jul 11, 2025
Merged

HAR-10096 Strikethrough toolbar item#656
edoversb merged 2 commits intodevelopfrom
har-10096_strikethrough-toolbar

Conversation

@VladaHarbour
Copy link
Copy Markdown
Contributor

No description provided.

@linear
Copy link
Copy Markdown

linear Bot commented Jul 11, 2025

bold,
italic,
underline,
strikethrough,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test the toolbar in webapp with this new item, does it fit on a small screen (mac) or not. As far as I remember, even without this new item there were already issues related to the width of the toolbar.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on those breakpoints
Screenshot 2025-07-11 at 15 34 51
Screenshot 2025-07-11 at 15 35 40
Screenshot 2025-07-11 at 15 36 46

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And desktop (1440px)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed an adjustment and it looks like this
Screenshot 2025-07-11 at 16 42 57
But there is no space left for another icon without hiding something in overflow

Copy link
Copy Markdown
Contributor

@artem-harbour artem-harbour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edoversb edoversb merged commit f987ba0 into develop Jul 11, 2025
3 checks passed
@edoversb edoversb deleted the har-10096_strikethrough-toolbar branch July 11, 2025 19:30
falsaadehh pushed a commit that referenced this pull request Jul 11, 2025
…ugh-toolbar

HAR-10096 Strikethrough toolbar item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants