HAR-6913 - super-editor: strikethrough and underline#7
Closed
mattConnHarbour wants to merge 1 commit intoartem-super-editorfrom
Closed
HAR-6913 - super-editor: strikethrough and underline#7mattConnHarbour wants to merge 1 commit intoartem-super-editorfrom
mattConnHarbour wants to merge 1 commit intoartem-super-editorfrom
Conversation
Contributor
Author
|
using this: #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for teeing this up :)
This branch comes from Artem's branch, so I'm using his as the trunk.
fyi: I had some issues with this line in
packages/super-editor/src/extensions/Comments/comments.js:import { v4 as uuidv4 } from 'uuid';I think we might need to change it to
uuidv4? But I see this is imported asuuideverywhere else so maybe it's just a problem for me?