Skip to content

fix(text indent): parse unit on export #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harbournick merged 3 commits into from
Aug 18, 2025
Merged

fix(text indent): parse unit on export #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
644a94e
fix(text indent): parse unit on export
VladaHarbour Aug 18, 2025
ba630ae
fix: change let to const
VladaHarbour Aug 18, 2025
208552c
chore: add jdsoc to new indent export function
harbournick Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/super-editor/src/core/super-converter/exporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { EditorState } from 'prosemirror-state';
import { SuperConverter } from './SuperConverter.js';
import {
emuToPixels,
getTextIndentExportValue,
inchesToTwips,
linesToTwips,
pixelsToEightPoints,
Expand Down Expand Up @@ -280,7 +281,7 @@ function generateParagraphProperties(node) {
if (hanging || hanging === 0) attributes['w:hanging'] = pixelsToTwips(hanging);

if (textIndent && !attributes['w:left']) {
attributes['w:left'] = inchesToTwips(textIndent);
attributes['w:left'] = getTextIndentExportValue(textIndent);
}

const indentElement = {
Expand All @@ -292,7 +293,7 @@ function generateParagraphProperties(node) {
const indentElement = {
name: 'w:ind',
attributes: {
'w:left': inchesToTwips(textIndent),
'w:left': getTextIndentExportValue(textIndent),
},
};
pPrElements.push(indentElement);
Expand Down
17 changes: 17 additions & 0 deletions packages/super-editor/src/core/super-converter/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,22 @@ function ptToTwips(pt) {
return pt * 20;
}

/**
* Get the export value for text indent
* @param {string|number} indent - The text indent value to export
* @returns {number} - The export value in twips
*/
const getTextIndentExportValue = (indent) => {
const [value, unit] = parseSizeUnit(indent);
const functionsMap = {
pt: ptToTwips,
in: inchesToTwips,
};

const exportValue = functionsMap[unit] ? functionsMap[unit](value) : pixelsToTwips(value);
return exportValue;
};

const getArrayBufferFromUrl = async (input, isHeadless) => {
// Check if it's a full URL or blob/file/data URI
const isLikelyUrl = /^https?:|^blob:|^file:|^data:/i.test(input);
Expand Down Expand Up @@ -230,4 +246,5 @@ export {
getLineHeightValueString,
deobfuscateFont,
hasSomeParentWithClass,
getTextIndentExportValue,
};
Loading