Skip to content

chore: add jsdocs + extension docs auto-gen#783

Merged
harbournick merged 20 commits intodevelopfrom
feature/har-10244-4-superdoc-docs-automate-documentation-generation-for
Aug 22, 2025
Merged

chore: add jsdocs + extension docs auto-gen#783
harbournick merged 20 commits intodevelopfrom
feature/har-10244-4-superdoc-docs-automate-documentation-generation-for

Conversation

@caio-pizzol
Copy link
Copy Markdown
Contributor

No description provided.

@caio-pizzol caio-pizzol requested a review from Copilot August 18, 2025 14:55
Comment thread .github/workflows/trigger-docs-update.yml Dismissed

This comment was marked as outdated.

Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that we're adding this! Generally looking good - just have a lot of questions.
I tend to think we should actually stop using field-annotation for this initially and use a much simpler node (maybe document sections?) to validate the whole process since there so much happening here between ensuring types are generated correctly, JSDoc validations etc.

Comment thread eslint.config.docs.mjs Outdated
Comment thread eslint.config.docs.mjs Outdated
Comment thread package.json Outdated
Comment thread packages/super-editor/tsconfig.json
Comment thread packages/super-editor/tsconfig.json Outdated
Comment thread packages/superdoc/src/core/SuperDoc.js Outdated
Comment thread packages/superdoc/src/core/SuperDoc.js Outdated
Comment thread packages/super-editor/src/extensions/field-annotation/types.d.ts Outdated
@caio-pizzol caio-pizzol changed the title docs: add GHA workflow to trigger documentation updates chore: add jsdocs + extension docs auto-gen Aug 21, 2025
@caio-pizzol caio-pizzol self-assigned this Aug 21, 2025
@caio-pizzol
Copy link
Copy Markdown
Contributor Author

Great that we're adding this! Generally looking good - just have a lot of questions. I tend to think we should actually stop using field-annotation for this initially and use a much simpler node (maybe document sections?) to validate the whole process since there so much happening here between ensuring types are generated correctly, JSDoc validations etc.

I liked your approach! Let me switch to Document Sections then (new docs are not official as well, so we can test it end to end first)

Comment thread packages/super-editor/tsconfig.json
Comment thread packages/super-editor/tsconfig.json Outdated
Comment thread packages/super-editor/tsconfig.build.json Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds JSDoc documentation standards and automatic documentation generation for the super-editor extensions. The changes establish TypeScript configuration for type checking, implement JSDoc linting rules, and set up a GitHub workflow to trigger documentation updates when extension files are modified.

  • Added JSDoc type definitions and documentation to document-section extension
  • Configured TypeScript compiler for type generation and checking
  • Set up ESLint with JSDoc plugin for documentation validation
  • Created GitHub workflow to auto-trigger documentation repository updates

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/super-editor/tsconfig.json Updated TypeScript config for type generation with new target and output directory
packages/super-editor/tsconfig.build.json New build-specific TypeScript configuration extending base config
packages/super-editor/src/extensions/structured-content/document-section.js Added comprehensive JSDoc type definitions and improved command documentation
packages/super-editor/package.json Updated build scripts to use new TypeScript configuration and added type checking commands
package.json Added ESLint JSDoc plugin and new linting commands for documentation validation
eslint.config.docs.mjs New ESLint configuration specifically for JSDoc validation in extension files
.github/workflows/trigger-docs-update.yml New GitHub workflow to trigger documentation updates when extensions change

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/super-editor/tsconfig.json
Comment thread packages/super-editor/src/extensions/structured-content/document-section.js Outdated
@caio-pizzol caio-pizzol enabled auto-merge (squash) August 21, 2025 22:37
…ns (#798)

* chore: add vite aliases to tsconfig

* fix: remove ts-ignore and fix issues to ensure file builds
Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick disabled auto-merge August 22, 2025 01:10
@harbournick harbournick merged commit a943c94 into develop Aug 22, 2025
5 of 7 checks passed
@harbournick harbournick deleted the feature/har-10244-4-superdoc-docs-automate-documentation-generation-for branch August 22, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants