Skip to content

fix: automatically insert blank docx if SuperEditor file is not docx type #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caio-pizzol merged 1 commit into from
Aug 22, 2025
Merged

fix: automatically insert blank docx if SuperEditor file is not docx type #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions packages/super-editor/src/components/SuperEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,12 @@ import Ruler from './rulers/Ruler.vue';
import GenericPopover from './popovers/GenericPopover.vue';
import LinkInput from './toolbar/LinkInput.vue';
import { checkNodeSpecificClicks } from './cursor-helpers.js';
import { getFileObject } from '@harbour-enterprises/common';
import BlankDOCX from '@harbour-enterprises/common/data/blank.docx?url';

const emit = defineEmits(['editor-ready', 'editor-click', 'editor-keydown', 'comments-loaded', 'selection-update']);

const DOCX = 'application/vnd.openxmlformats-officedocument.wordprocessingml.document';
const props = defineProps({
documentId: {
type: String,
Expand Down Expand Up @@ -44,6 +47,8 @@ const editor = shallowRef(null);
const editorWrapper = ref(null);
const editorElem = ref(null);

const fileSource = ref(null);

/**
* Generic popover controls including state, open and close functions
*/
Expand Down Expand Up @@ -95,8 +100,14 @@ const pollForMetaMapData = (ydoc, retries = 10, interval = 500) => {
};

const loadNewFileData = async () => {
fileSource.value = props.fileSource;
if (!fileSource.value || fileSource.value.type !== DOCX) {
fileSource.value = await getFileObject(BlankDOCX, 'blank.docx', DOCX);
console.debug('file source', fileSource.value);
}

try {
const [docx, media, mediaFiles, fonts] = await Editor.loadXmlData(props.fileSource);
const [docx, media, mediaFiles, fonts] = await Editor.loadXmlData(fileSource.value);
return { content: docx, media, mediaFiles, fonts };
} catch (err) {
console.debug('Error loading new file data:', err);
Expand Down Expand Up @@ -137,7 +148,7 @@ const initEditor = async ({ content, media = {}, mediaFiles = {}, fonts = {} } =
editor.value = new Editor({
mode: 'docx',
element: editorElem.value,
fileSource: props.fileSource,
fileSource: fileSource.value,
extensions: getExtensions(),
externalExtensions: props.options.externalExtensions,
documentId: props.documentId,
Expand Down
2 changes: 1 addition & 1 deletion packages/super-editor/src/dev/components/BasicUpload.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const onFileChange = (event) => {

<template>
<div>
<input type="file" id="fileInput" @change="onFileChange" accept=".docx" />
<input type="file" id="fileInput" @change="onFileChange" accept=".docx .md" />
</div>
</template>

Expand Down
2 changes: 1 addition & 1 deletion packages/super-editor/src/dev/components/DeveloperPlayground.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ onMounted(async () => {
</div>
<div class="dev-app__header-upload">
Upload docx
<BasicUpload @file-change="handleNewFile" accept=".docx" />
<BasicUpload @file-change="handleNewFile" />
</div>
</div>
<div class="dev-app__header-side dev-app__header-side--right">
Expand Down