Fix: list outdent and lint#855
Merged
Merged
Conversation
Collaborator
harbournick
commented
Sep 2, 2025
- Fixes issue with list outdent converting from bullet to numbered
- lint fixes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with list outdenting behavior that was incorrectly converting bullet lists to numbered lists and includes various lint fixes.
- Fixed logic in
decreaseListIndent.jsto prevent list type conversion during outdent operations - Updated test cases to verify the fix and align with new behavior expectations
- General code cleanup including removal of unused variables and comment fixes
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/super-editor/src/core/commands/toggleList.js |
Removed unused switchingToOrdered variable |
packages/super-editor/src/core/commands/decreaseListIndent.test.js |
Updated tests to reflect new list outdent behavior and removed outdated comment |
packages/super-editor/src/core/commands/decreaseListIndent.js |
Fixed core logic to adopt parent list IDs and prevent definition regeneration |
packages/super-editor/src/core/commands/backspaceNextToList.js |
Removed unused listDepth variable |
packages/ooxml-inspector/src/children/cli.js |
Fixed template literal syntax in error message |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
Author
|
🎉 This PR is included in version 0.16.0-next.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.