Skip to content

Log error when insert_db_version fails #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

Log error when insert_db_version fails #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion core/rs/core/src/changes_vtab_write.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,14 @@ unsafe fn merge_insert(

// Update the received db_version whether the change won or not.
if res.is_ok() && !insert_site_id.is_empty() {
insert_db_version((*tab).pExtData, insert_site_id, insert_db_vrsn)?;
if let Err(rc) = insert_db_version((*tab).pExtData, insert_site_id, insert_db_vrsn) {
let err = CString::new(format!(
"Unable to insert db version {} for site id {:?}",
insert_db_vrsn, insert_site_id
))?;
*errmsg = err.into_raw();
return Err(rc);
}
}

res
Expand Down
Loading